-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function to get specific app's details #470
Conversation
56c2677
to
8386477
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 412 +1
Lines 34153 34187 +34
=======================================
+ Hits 33218 33252 +34
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 412 +1
Lines 34153 34187 +34
=======================================
+ Hits 33218 33252 +34
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 411 412 +1
Lines 34153 34187 +34
=======================================
+ Hits 33218 33252 +34
Misses 935 935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 442 443 +1
Lines 34882 34916 +34
=======================================
+ Hits 33938 33972 +34
Misses 944 944
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Adds `get_specific_github_app_details` function to bots service. This allows us to get `GithubInstallationInfo` for the app we want. It fails with a new exception if the app can't be found. This is because this feature will be used to get the app that made a comment or status check. If we don't use the same to edit said comment it won't work. On top of that we need to start saving the ID of the apps we selected for Torngit adapter instances
8386477
to
6b8670d
Compare
I broke the GH fallback system again 😅 Fixes this issue: https://l.codecov.dev/dEsZeK The problem is that since #225 (technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`. This is breaking the function that gets tokens because we are destructuring the info dict into the kwargs for the function (with the extra, unexpected `id` one). To fix that we just pop it before calling the function.
I broke the GH fallback system again 😅 Fixes this issue: https://l.codecov.dev/dEsZeK The problem is that since #225 (technically codecov/worker#470 actually) we include 1 extra piece of information in `GitHubAppInstallationInfo`, the `GitHubAppInstallation.id`. This is breaking the function that gets tokens because we are destructuring the info dict into the kwargs for the function (with the extra, unexpected `id` one). To fix that we just pop it before calling the function.
Adds
get_specific_github_app_details
function to bots service.This allows us to get
GithubInstallationInfo
for the app we want.It fails with a new exception if the app can't be found.
This is because this feature will be used to get the app that made a comment
or status check. If we don't use the same app to edit said comment it won't work.
On top of that we need to start saving the ID of the apps we selected for Torngit adapter instances
👀 This commit is part 2/4 of a bigger change that is actually done, but I decided to break it up into multiple PRs so it's easier to review. See how it plays with the rest here: main...gio/pin-commit-to-ghapp
(I'll try to leave the original branch up to date best as I can)